fix(component): add docs overview #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for af0e3ec at https://previews.ngrx.io/pr2444-af0e3ec/ |
Co-Authored-By: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
BioPhoton
force-pushed
the
2442_add-docs-overview-page-content
branch
from
b073afe
to
af0e3ec
Compare
|
After syncing with master I run into some cypress related problems: Not sure how this is related to the PR but if I can do anything please let me know. |
timdeschryver
approved these changes
Mar 29, 2020
There was a problem hiding this comment.
LGTM
Fyi, about the build I was noticing a lot of new builds were failing, I was trying it out here
Somehow that fixed it for all branches (after a retrigger)? Perhaps with the default cache key that now has a cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added link to docs intro page. Created content for the components index pag and linked let and push docs.
related to #2441 closes #2442