Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-store): export EffectReturnFn interface #2555

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Export EffectReturnFn as well, otherwise we get an error:

error TS4029: Public property 'effectName' of exported class has or is using name 'EffectReturnFn' from external module "path/to/ngrx/modules/component-store/src/component-store" but cannot be named
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 2, 2020

Preview docs changes for b9b4253 at https://previews.ngrx.io/pr2555-b9b4253/

@brandonroberts brandonroberts merged commit f2a2212 into ngrx:master Jun 3, 2020
BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants