Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support factory selectors in the extraSelectors property of createFeature() #3768

Closed
1 of 2 tasks
pablomaurer opened this issue Feb 6, 2023 · 2 comments
Closed
1 of 2 tasks

Comments

@pablomaurer
Copy link
Contributor

Which @ngrx/* package(s) are relevant/related to the feature request?

store

Information

Recently the great @markostanimirovic created the cool feature #3744 to support extraSelectors in the createFeature() function. But extraSelectors does not support factory selectors which is needed if the selector needs any parameters.

Would be really cool if extraSelectors would support factory selectors.

Describe any alternatives/workarounds you're currently using

Just use createFeature() like before extraSelectors where available as documented in #3719

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@pablomaurer pablomaurer changed the title Support returning factory selectors in the extraSelectors property of createFeature() Support factory selectors in the extraSelectors property of createFeature() Feb 6, 2023
@markostanimirovic
Copy link
Member

Hey Pablo 👋

I already fixed this issue in this PR: #3767

It will be published in the next NgRx version. 🚀

@pablomaurer
Copy link
Contributor Author

You're too fast! 🚀 Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants