Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-devtools): correctly import state when feature is set to true #3855

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3636

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

While testing this in a react app the behavior was identical.
Setting the import feature to true resulted in the same error.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 40ea7e7
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64440728deb71a0008e2b78a
😎 Deploy Preview https://deploy-preview-3855--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@timdeschryver timdeschryver changed the title fix(devtools): correctly state when feature is set to true fix(devtools): correctly import state when feature is set to true Apr 23, 2023
@markostanimirovic markostanimirovic changed the title fix(devtools): correctly import state when feature is set to true fix(store-devtools): correctly import state when feature is set to true Apr 24, 2023
@markostanimirovic markostanimirovic merged commit 0df3419 into master Apr 24, 2023
@markostanimirovic markostanimirovic deleted the devtools/fix-import-true branch April 24, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import saved store state using devtools package
3 participants