Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(effects): make correct export path for testing module #96

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

jeffbcross
Copy link
Contributor

Closes #94

@jeffbcross
Copy link
Contributor Author

When I diff the dist folder before and after this change, the only changed file is dist/effects/testing.d.ts

Before:
export * from './effects/testing/index';

After:
export * from './testing/testing';

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.365% when pulling 986b07c on jeffbcross:fix-testing into 6982952 on ngrx:master.

@jeffbcross
Copy link
Contributor Author

And I verified that this fixes the error in my application.

@vsavkin vsavkin assigned vsavkin and jeffbcross and unassigned vsavkin Jul 18, 2017
@vsavkin
Copy link
Contributor

vsavkin commented Jul 18, 2017

LGTM

@MikeRyanDev MikeRyanDev merged commit a5aad22 into ngrx:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants