Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MsSqlConnectionStringBuilder to remove System.Data.SqlClient dependency #393

Closed
jrgcubano opened this issue Mar 21, 2018 · 2 comments

Comments

@jrgcubano
Copy link
Member

We need to change MsSqlConnectionStringBuilder "ToString" implementation so we can remove the need for System.Data.SqlClient.SqlConnectionStringBuilder and System.Data.SqlClient package.

Basic refactor idea:

Follow the same implementation as MySQLConnectionStringBuilder.

@danilobreda
Copy link
Contributor

danilobreda commented Mar 22, 2018

I will submit a PR for this. #395

@danilobreda
Copy link
Contributor

@jrgcubano the PR is done, i am open for revision.
I think this is very important to target the 2.1.1 milestone.

I did not remove the package dependency yet (i don't know how to do it on the right way).

@jrgcubano jrgcubano changed the title Remove System.Data.SqlClient package dependency from project Refactor MsSqlConnectionStringBuilder to remove System.Data.SqlClient dependency Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants