Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did you choose libwebp #23

Open
a-little-cat opened this issue Apr 8, 2021 · 1 comment
Open

Why did you choose libwebp #23

a-little-cat opened this issue Apr 8, 2021 · 1 comment

Comments

@a-little-cat
Copy link

I read the code about file input and save.
And I found that libwebp is used to read and write png, jpeg, webp file.
I am wondering why did you choose libwebp instead of opencv?
Maybe opencv can handle this questions with more simple code.

@mirh
Copy link

mirh commented Feb 4, 2022

https://github.com/nihui/realsr-ncnn-vulkan/blob/20210210/src/main.cpp#L215
You seem to have found wrong, because libwebp is just the the first loader that is tried on read.
If it fails (because webp_load should do what it's written on the tin) everything else is still expectably handled with WIC/stbi.

If any I find it strange that there are some pointless/duplicated #if _WIN32 conditionals
https://github.com/nihui/realsr-ncnn-vulkan/blob/20210210/src/webp_image.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants