Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undici failures #1051

Closed
targos opened this issue Mar 7, 2024 · 21 comments · Fixed by nodejs/undici#3413
Closed

Undici failures #1051

targos opened this issue Mar 7, 2024 · 21 comments · Fixed by nodejs/undici#3413

Comments

@Uzlopak
Copy link

Uzlopak commented Mar 7, 2024

Connected with nodejs/node#51997

@targos
Copy link
Member Author

targos commented Mar 7, 2024

Is it? The run was done after the revert.

@Uzlopak
Copy link

Uzlopak commented Mar 7, 2024

Does the citgm connect via debug port?

@targos
Copy link
Member Author

targos commented Mar 7, 2024

Not sure I understand the question but probably not.
I basically does npm install followed by npm test

@KhafraDev
Copy link
Member

 test at test/node-test/debug.js:54:1
  debug#fetch (346.571414ms)
   AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
   
   4 !== 6
   
       at res.<computed> [as strictEqual] (/home/iojs/tmp/citgm_tmp/19886eeb-1a0b-44d6-951c-284ce1a45418/undici/node_modules/@matteo.collina/tspl/tspl.js:52:35)
       at Socket.<anonymous> (/home/iojs/tmp/citgm_tmp/19886eeb-1a0b-44d6-951c-284ce1a45418/undici/test/node-test/debug.js:79:12)
       at Socket.emit (node:events:531:35)
       at endReadableNT (node:internal/streams/readable:1696:12)
       at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
     actual: 4,
     expected: 6,
     operator: 'strictEqual'
   }
 test at test/node-test/debug.js:89:1
  debug#undici (186.572836ms)
   AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
   
   21 !== 6
   
       at res.<computed> [as strictEqual] (/home/iojs/tmp/citgm_tmp/19886eeb-1a0b-44d6-951c-284ce1a45418/undici/node_modules/@matteo.collina/tspl/tspl.js:52:35)
       at Socket.<anonymous> (/home/iojs/tmp/citgm_tmp/19886eeb-1a0b-44d6-951c-284ce1a45418/undici/test/node-test/debug.js:117:12)
       at Socket.emit (node:events:531:35)
       at endReadableNT (node:internal/streams/readable:1696:12)
       at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
     actual: 21,
     expected: 6,
     operator: 'strictEqual'
   }
 test at test/node-test/autoselectfamily.js:1:1
  test/node-test/autoselectfamily.js (30000.124732ms)
   'test timed out after 30000ms'

related to nodejs/undici#2600

@targos
Copy link
Member Author

targos commented Mar 7, 2024

Ok, so we have to wait for the next libuv update.

@KhafraDev
Copy link
Member

it looked like a different error to me, this test has had quite a few failures cc @metcoder95

@Uzlopak
Copy link

Uzlopak commented Mar 7, 2024

yeah, it is an annoying file

@metcoder95
Copy link
Member

Ok... that's new, the mismatch on the assertions is weird; I'll try to revisit this and possibly rewrite the testing scenarios, haven't had the time yet.

If this is a blocker of some sort, feel free to skip them for now

@Uzlopak
Copy link

Uzlopak commented Mar 10, 2024

Should now work as we patched the failing test.

@targos
Copy link
Member Author

targos commented Mar 13, 2024

@targos
Copy link
Member Author

targos commented Mar 13, 2024

On OSX:

09:22:16 error:                     | ✖ failing tests:                                                                          
09:22:16 error:                     |                                                                                           
09:22:16 error:                     | test at test/issue-803.js:1:1                                                             
09:22:16 error:                     | ✖ test/issue-803.js (30147.778213ms)                                                      
09:22:16 error:                     | 'test timed out after 30000ms'                                                            
09:22:16 error:                     |                               

@Uzlopak
Copy link

Uzlopak commented Mar 13, 2024

create a PR to add macos-latest to our ci

nodejs/undici#2952

@mcollina
Copy link
Member

@KhafraDev
Copy link
Member

 test at test/issue-803.js:1:1
  test/issue-803.js (30101.051783ms)
   'test timed out after 30000ms'

@Uzlopak

@Uzlopak
Copy link

Uzlopak commented Mar 21, 2024

What should I do? The test has afaik already a timeout of 60000ms. So failing after 30000 ms, makes no sense.

@metcoder95
Copy link
Member

Maybe refactor to AsyncIterable to see if it’s more deterministic?
Just throwing ideas

@mcollina
Copy link
Member

Just skip the test if citgm.

@Uzlopak
Copy link

Uzlopak commented Mar 22, 2024

Is there a env variable set in case of citgm?

@targos
Copy link
Member Author

targos commented Mar 22, 2024

I don't think you can specifically detect citgm by default, but you can add custom env variables using the envVar key in the lookup.

Example:

citgm/lib/lookup.json

Lines 245 to 252 in 12e6902

"jose": {
"maintainers": ["panva"],
"prefix": "v",
"scripts": ["test", "tap:node"],
"envVar": { "CITGM": true },
"skip": ["aix"],
"comment": "esbuild doesn't support aix"
},

@mcollina
Copy link
Member

I've released v6.19.3 that should address some of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants