From 2b01fc683a7032fa4eeb7350bf02dce00887fa2d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 31 Mar 2022 16:11:14 -0700 Subject: [PATCH] Update doc/contributing/pull-requests.md Co-authored-by: Mohammed Keyvanzadeh --- doc/contributing/pull-requests.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 8aace4c1997ff7..7a9e1a051e7b50 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -514,15 +514,14 @@ Only Node.js core collaborators and triagers can start a CI testing run. The specific details of how to do this are included in the new collaborator [Onboarding guide][]. Usually, a collaborator or triager will start a CI test run for you as approvals for the pull request come in. -If not, you can ask a collaborator to start a CI run. +If not, you can ask a collaborator or triager to start a CI run. Ideally, the code change will pass ("be green") on all platform configurations -supported by Node.js. (There are over 30 platform configurations currently.) -This means that all tests pass and there are no linting errors. In reality, -however, it is not uncommon for the CI infrastructure itself to fail on -specific platforms or for so-called "flaky" tests to fail ("be red"). It is -vital to visually inspect the results of all failed ("red") tests to determine -whether the failure was caused by the changes in the pull request. +supported by Node.js. This means that all tests pass and there are no linting +errors. In reality, however, it is not uncommon for the CI infrastructure itself +to fail on specific platforms or for so-called "flaky" tests to fail ("be red"). +It is vital to visually inspect the results of all failed ("red") tests to +determine whether the failure was caused by the changes in the pull request. ## Notes