Skip to content

Commit

Permalink
build, tools, win: add .S files support to GYP
Browse files Browse the repository at this point in the history
Makes GYP properly handle .S files.

Fixes: nodejs/node-v8#89

PR-URL: #24553
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
bzoz authored and targos committed Nov 29, 2018
1 parent 899e7c3 commit 383d809
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/gyp/pylib/gyp/generator/msvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2156,6 +2156,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
A pair of (group this file should be part of, the label of element)
"""
_, ext = os.path.splitext(source)
ext = ext.lower()
if ext in extension_to_rule_name:
group = 'rule'
element = extension_to_rule_name[ext]
Expand All @@ -2168,7 +2169,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
elif ext == '.rc':
group = 'resource'
element = 'ResourceCompile'
elif ext == '.asm':
elif ext in ['.s', '.asm']:
group = 'masm'
element = 'MASM'
elif ext == '.idl':
Expand Down

0 comments on commit 383d809

Please sign in to comment.