From 81f4fb2b3b8cdc37e8228b1c75f5b7adb590bc2d Mon Sep 17 00:00:00 2001 From: alyssaq Date: Tue, 6 Nov 2018 14:34:52 +0000 Subject: [PATCH] src: reuse std::make_unique Ref: https://github.com/nodejs/node/commit/283a967e356311a467113eea450a81827d43c969 PR-URL: https://github.com/nodejs/node/pull/24132 Refs: https://github.com/nodejs/node/commit/283a967e356311a467113eea450a81827d43c969 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Eugene Ostroukhov --- src/inspector_agent.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index e22e8ee9592921..e0ee24a7f0c215 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -475,11 +475,9 @@ class NodeInspectorClient : public V8InspectorClient { bool prevent_shutdown) { events_dispatched_ = true; int session_id = next_session_id_++; - // TODO(addaleax): Revert back to using make_unique once we get issues - // with CI resolved (i.e. revert the patch that added this comment). - channels_[session_id].reset( - new ChannelImpl(env_, client_, getWorkerManager(), - std::move(delegate), prevent_shutdown)); + channels_[session_id] = + std::make_unique(env_, client_, getWorkerManager(), + std::move(delegate), prevent_shutdown); return session_id; }