Skip to content

Commit

Permalink
src: remove V8_FT_ADAPTOR for V8 update
Browse files Browse the repository at this point in the history
V8 has removed argument adapter frames. This commit removes them
from the Node.js codebase as well.

PR-URL: #37587
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Mar 15, 2021
1 parent 9843361 commit b1c1c46
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
1 change: 0 additions & 1 deletion src/v8abbr.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
#define V8_FT_OPTIMIZED V8DBG_FRAMETYPE_OPTIMIZEDFRAME
#define V8_FT_INTERNAL V8DBG_FRAMETYPE_INTERNALFRAME
#define V8_FT_CONSTRUCT V8DBG_FRAMETYPE_CONSTRUCTFRAME
#define V8_FT_ADAPTOR V8DBG_FRAMETYPE_ARGUMENTSADAPTORFRAME
#define V8_FT_STUB V8DBG_FRAMETYPE_STUBFRAME

/* Identification masks and tags */
Expand Down
18 changes: 0 additions & 18 deletions src/v8ustack.d
Original file line number Diff line number Diff line change
Expand Up @@ -392,24 +392,6 @@ dtrace:helper:ustack:
this->ii = 0;
}

/*
* Like V8, we first check if we've got an ArgumentsAdaptorFrame. We've got
* nothing to add for such frames, so we bail out quickly.
*/
dtrace:helper:ustack:
{
this->ctx = COPYIN_PTR(this->fp + V8_OFF_FP_CONTEXT);
}

dtrace:helper:ustack:
/IS_SMI(this->ctx) && SMI_VALUE(this->ctx) == V8_FT_ADAPTOR/
{
this->done = 1;
APPEND_CHR8('<','<',' ','a','d','a','p','t');
APPEND_CHR8('o','r',' ','>','>','\0','\0','\0');
stringof(this->buf);
}

/*
* Check for other common frame types for which we also have nothing to add.
*/
Expand Down

0 comments on commit b1c1c46

Please sign in to comment.