Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for nested arrays on brillig gen #2029

Merged
merged 6 commits into from
Jul 25, 2023
Merged

feat: Add support for nested arrays on brillig gen #2029

merged 6 commits into from
Jul 25, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 25, 2023 •
edited
Loading

Description

Problem*

Resolves #2028

Summary*

Adds support for nested arrays in brillig_gen and also in the entrypoint by deflattening/flattening (ACIR passes/receives nested arrays to brillig flattened)

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant marked this pull request as draft July 25, 2023 16:19
@sirasistant sirasistant marked this pull request as ready for review July 25, 2023 16:31
@sirasistant sirasistant added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit 8adc57c Jul 25, 2023
6 checks passed
@sirasistant sirasistant deleted the arv/nested_arrays branch July 25, 2023 17:45
@kevaundray kevaundray mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@ludamad ludamad Awaiting requested review from ludamad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for nested arrays on unconstrained functions
2 participants
@sirasistant @kevaundray