Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssa): fix the compile-time check for equality in acir-gen #904

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

guipublic
Copy link
Contributor

Description

Summary of changes

Check for equality before creating a witness and a constraint, in case the equality is known at compile-time.

Test additions / changes

This issue happens with the poseidonsponge_x5_254 test, but it is not part of the CI because it would be too long.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

@kevaundray kevaundray self-requested a review February 24, 2023 10:57
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@kevaundray kevaundray added this pull request to the merge queue Feb 24, 2023
Merged via the queue into master with commit 161e4fb Feb 24, 2023
@kevaundray kevaundray deleted the gd/fix_cmp_for_equal branch February 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants