Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Provide PackageConfig module for CMake #1096

Open
breznak opened this issue Sep 21, 2016 · 5 comments
Open

Provide PackageConfig module for CMake #1096

breznak opened this issue Sep 21, 2016 · 5 comments

Comments

@breznak
Copy link
Member

breznak commented Sep 21, 2016

so nupic.core libraries can be easily detected & included by 3rd party C++ programs.

https://cmake.org/Wiki/CMake:How_To_Find_Libraries

EDIt: reference of others
https://github.com/numenta/nupic.core/blob/master/CMakeLists.txt

Ok, an update, we probably shouldn't write our own FindXXX.cmake

Do not write find modules for packages that themselves build with CMake. Instead provide a CMake
package configuration file with the package itself. See our tutorials on CMake Packages.
But, instead just create a package config

https://cmake.org/Wiki/CMake/Tutorials/Packaging
https://cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file

The desired result is:
We can call find_package(NupicCore) in an external cmake repo and use the includes/libraries/binaries/flags from this project.

@rhyolight
Copy link
Member

@numenta/nupic-committers Haven't we tried this before?

@oxtopus
Copy link
Contributor

oxtopus commented Sep 23, 2016

Not exactly. I think @breznak is suggesting we provide a generic CMake module so that consumers of nupic.core can integrate it easily into their own CMake builds. 👍 from me.

@scottpurdy
Copy link
Contributor

👍 from me as well

@breznak
Copy link
Member Author

breznak commented Mar 2, 2017

Bump. Is anyone linking their 3rd party (cmake based) app to nupic.core?

Ok, an update, we probably shouldn't write our own FindXXX.cmake

Do not write find modules for packages that themselves build with CMake. Instead provide a CMake package configuration file with the package itself. See our tutorials on CMake Packages.

But, instead just create a package config
https://cmake.org/Wiki/CMake/Tutorials/Packaging
https://cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file

@rhyolight
Copy link
Member

Thanks for the update. No one is currently planning on working on this at the moment.

@breznak breznak changed the title Provide FindNupic find module for CMake Provide PackageConfig module for CMake Apr 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants