Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not warn when using runtimeConfig to set url and key #281

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: do not warn when using runtimeConfig to set url and key #281

merged 2 commits into from
Oct 6, 2023

Conversation

stafyniaksacha
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When using runtimeConfig environment variables, everything works, but a warning appear.

This PR test key and url after having merged module with runtimeConfig to detect if they are provided.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@netlify
Copy link

netlify bot commented Sep 28, 2023

👷 Deploy request for n3-supabase pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4893b60

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Sep 28, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
supabase Edit on Studio ↗︎ View Live Preview 4893b60

larbish
larbish approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@larbish larbish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@larbish larbish merged commit 8c15173 into nuxt-modules:main Oct 6, 2023
@larbish larbish mentioned this pull request Oct 6, 2023
Closed
@stafyniaksacha stafyniaksacha deleted the fix-runtime-config branch October 11, 2023 15:03
danielroe pushed a commit that referenced this pull request Mar 25, 2024
@stafyniaksacha @danielroe
fix(module): do not warn when using runtimeConfig to set url and key (#…
2507d37 
…281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larbish larbish larbish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stafyniaksacha @larbish