Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP error in http #510

Closed
arashsheyda opened this issue Nov 7, 2023 · 4 comments · Fixed by #522
Closed

PIP error in http #510

arashsheyda opened this issue Nov 7, 2023 · 4 comments · Fixed by #522
Labels
documentation Improvements or additions to documentation

Comments

@arashsheyda
Copy link
Member

🐛 The bug

PIP feature is throwing an error in http only

Uncaught (in promise) DOMException: Failed to execute 'requestWindow' on 'DocumentPictureInPicture': Opening a PiP window requires https or file protocol

I tried it and it did work on https

🛠️ To reproduce

n/a

🌈 Expected behavior

to work on http

ℹ️ Additional context

No response
@arashsheyda arashsheyda added the bug Something isn't working label Nov 7, 2023
@arashsheyda arashsheyda changed the title PIP error in http mode PIP error in http Nov 7, 2023
@antfu
Copy link
Member

antfu commented Nov 11, 2023

Do you have a custom hostname? IIRC it works with localhost on http

@arashsheyda
Copy link
Member Author

no nothing special, but It can be fixed simply by using https option of nuxt

@antfu
Copy link
Member

antfu commented Nov 20, 2023

I guess there is nothing we could do on our side if it's a browser limitation. We could improve the UI to indicate better how to workaround this when it occurs. What do you think?

@antfu antfu added documentation Improvements or additions to documentation and removed bug Something isn't working labels Nov 20, 2023
@arashsheyda
Copy link
Member Author

Yes I totally agree

@arashsheyda arashsheyda mentioned this issue Nov 20, 2023
Merged
@nuxt nuxt deleted a comment from tarushnagpal Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pip): check for https support nuxt/devtools
2 participants
@antfu @arashsheyda