Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full fix for missing openssl/pkg-config during rust profiler compilation #780

Open
manopapad opened this issue Jul 3, 2023 · 0 comments
Assignees
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes

Comments

@manopapad
Copy link
Contributor

The Legion profiler recently added openssl and pkg-config to its requirements, causing builds to start failing. A workaround was included in #778, whereby the env generation scripts were updated to include the required packages.

However, by default the rust compiler will try to use the system OpenSSL, which is apparently too old, so we also had to tell the rust compiler to use the OpenSSL in the conda environment. The above PR does this by setting OPENSSL_DIR=$CONDA_PREFIX in install.py and conda/conda-build/build.sh

I believe the "proper" place to fix this would be get_legion.cmake, so the change will get picked up even if the user goes directly through cmake instead of using install.py. @trxcllnt can we update this file to "find" openssl during our embedded legion build (preferring the newer version under conda if available), and tell the rust compiler about it (through $OPENSSL_DIR)? I found https://cmake.org/cmake/help/latest/module/FindOpenSSL.html, but possibly there’s some rapids-cmake goodness we should prefer.

@sandeepd-nv we also need to make sure the openssl and pkg-config packages are included in our conda-build dependencies.

@manopapad manopapad added the category:bug-fix PR is a bug fix and will be classified as such in release notes label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug-fix PR is a bug fix and will be classified as such in release notes
Projects
None yet
Development

No branches or pull requests

3 participants