Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add new events via @octokit/webhooks-schemas update to v7.4.0 #985

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

harryzcy
Copy link

@harryzcy harryzcy commented Mar 12, 2024

Resolves #ISSUE_NUMBER


Before the change?

Update @octokit/webhooks-types for v12.x

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Please also update @octokit/webhooks-schemas

And run

npm run generate-types

@harryzcy
Copy link
Author

Please also update @octokit/webhooks-schemas

And run

npm run generate-types

Thanks, updated

@wolfy1339 wolfy1339 changed the title feat(deps): update @octokit/webhooks-types feat(types): add new events via @octokit/webhooks-schemas update to v7.4.0 Mar 23, 2024
@harryzcy
Copy link
Author

@wolfy1339 It seems that push-payload.json need to be updated. How can I find the correct test fixture?

@wolfy1339
Copy link
Member

You can copy the one from the main branch and it'll pass validation

@harryzcy
Copy link
Author

harryzcy commented Mar 24, 2024

It looks like push-payload.json from main doesn't have custom_properties as well

@wolfy1339 Thanks

@wolfy1339
Copy link
Member

It looks like push-payload.json from main doesn't have custom_properties as well

I saw that. It seems like the property is maybe not always present. 🤷‍♂️

@wolfy1339 wolfy1339 merged commit 9de507d into octokit:12.x Mar 24, 2024
4 checks passed
@harryzcy harryzcy deleted the 12.x branch March 24, 2024 00:05
@wolfy1339
Copy link
Member

The release is currently blocked by #991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants