Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error positioning #466

Open
sergei-maertens opened this issue Jun 22, 2023 · 2 comments
Open

Validation error positioning #466

sergei-maertens opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels
blocked Depends on something else that should be done first NL Design System owner: utrecht

Comments

@sergei-maertens
Copy link
Member

NL DS leans towards putting validation errors above the field (consistent with the gov.uk approach), while the Open Forms theme puts them below. We want to avoid users having to override the container/wrapper component layout just to achieve this, as there should be CSS-only solutions.

Possible options:

  • flex-direction row + the order property
  • CSS grid with named slots/subgrids
@sergei-maertens sergei-maertens added this to the SDK 1.5.0 milestone Jun 22, 2023
@sergei-maertens sergei-maertens modified the milestones: SDK 1.5.0, SDK 1.6.0 Aug 22, 2023
@sergei-maertens sergei-maertens modified the milestones: SDK 2.0, SDK 2.1 Nov 6, 2023
@vaszig vaszig added the blocked Depends on something else that should be done first label Dec 6, 2023
@vaszig
Copy link
Contributor

vaszig commented Dec 6, 2023

Open Forms is now showing the errors below the field and the same is happening for Utrecht.

https://open-formulieren.github.io/open-forms-sdk/?path=/story/pure-react-components-forms-textfield--validation-error

https://nl-design-system.github.io/utrecht/storybook/?path=/story/react_react-form-field--form-field-textbox

@sergei-maertens
Copy link
Member Author

Discussed with NL DS - the intent is indeed that the validation error is above the field, but their own storybook gives incorrect examples. They will update those components/examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Depends on something else that should be done first NL Design System owner: utrecht
Projects
None yet
Development

No branches or pull requests

3 participants