Skip to content

Commit

Permalink
pmix2x/pmix: fix a typo in PMIx_tool_init()
Browse files Browse the repository at this point in the history 
and remove now useless local variable i
  • Loading branch information
@ggouaillardet
ggouaillardet committed Jul 5, 2016
1 parent efce8cc commit 267821f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions opal/mca/pmix/pmix2x/pmix/src/tool/pmix_tool.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ PMIX_EXPORT int PMIx_tool_init(pmix_proc_t *proc,
pmix_kval_t *kptr;
pmix_status_t rc;
pmix_nspace_t *nptr, *nsptr;
int i, server_pid = -1;
int server_pid = -1;
int hostnamelen = 10;
char hostname[hostnamelen];
DIR *cur_dirp = NULL;
Expand Down Expand Up @@ -218,8 +218,8 @@ pmix_output(0, "TOOL INIT");
if (0 == strcmp(PMIX_EVENT_BASE, info[n].key)) {
pmix_globals.evbase = (pmix_event_base_t*)info[n].value.data.ptr;
pmix_globals.external_evbase = true;
} else if (strcmp(info[i].key, PMIX_SERVER_PIDINFO) == 0) {
server_pid = info[i].value.data.integer;
} else if (strcmp(info[n].key, PMIX_SERVER_PIDINFO) == 0) {
server_pid = info[n].value.data.integer;
}
}
}
Expand Down

3 comments on commit 267821f

@ggouaillardet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhc54 this issue was identified by Coverity with CID 1363039

i could not find the src/tool directory in pmix/master, can you please double check whether upstream pmix should be updated too ?

@rhc54
Copy link
Contributor

@rhc54 rhc54 commented on 267821f Jul 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it hasn't been committed yet upstream - we are waiting for a "second" on the PR

pmix/RFCs#1

@rhc54
Copy link
Contributor

@rhc54 rhc54 commented on 267821f Jul 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have upstreamed the fix in the PR associated with the PMIx RFC

Please sign in to comment.