diff --git a/NEWS b/NEWS index a7601ff8a58..c34f677b84b 100644 --- a/NEWS +++ b/NEWS @@ -7,7 +7,7 @@ ## # -## 1.6.0-rc2 (June 13, 2019) +## 1.6.0-rc3 (June 19, 2019) Features: - Modular architecture for UCT transports - ROCm transport re-design: support for managed memory, direct copy, ROCm GDR @@ -33,6 +33,8 @@ Bugfixes: - Fix data race in UCP proxy endpoint - Static checker fixes - Fallback to ibv_create_cq() if ibv_create_cq_ex() returns ENOSYS +- Fix malloc hooks test +- Fix checking return status in ucp_client_server example Tested configurations: - RDMA: MLNX_OFED 4.5, distribution inbox drivers, rdma-core 22.1 diff --git a/test/gtest/ucm/malloc_hook.cc b/test/gtest/ucm/malloc_hook.cc index a9e7f4ab316..3ee1324aa9a 100644 --- a/test/gtest/ucm/malloc_hook.cc +++ b/test/gtest/ucm/malloc_hook.cc @@ -1021,7 +1021,7 @@ UCS_TEST_F(malloc_hook, test_event_failed) { status = ucm_test_events(UCM_EVENT_VM_UNMAPPED); EXPECT_TRUE(status == UCS_ERR_UNSUPPORTED); - /* restore original mmap body */ + /* restore original munmap body */ status = ucm_bistro_restore(rp); ASSERT_UCS_OK(status); } @@ -1040,7 +1040,7 @@ UCS_TEST_F(malloc_hook, test_event_unmap) { UCS_TEST_SKIP_R("skipping on non-BISTRO hooks"); } - status = event.set(UCM_EVENT_MUNMAP); + status = event.set(UCM_EVENT_MMAP | UCM_EVENT_MUNMAP | UCM_EVENT_VM_UNMAPPED); ASSERT_UCS_OK(status); /* set hook to mmap call */ @@ -1048,13 +1048,19 @@ UCS_TEST_F(malloc_hook, test_event_unmap) { ASSERT_UCS_OK(status); EXPECT_NE((intptr_t)rp, NULL); + /* munmap should be broken */ status = ucm_test_events(UCM_EVENT_MUNMAP); EXPECT_TRUE(status == UCS_ERR_UNSUPPORTED); - status = ucm_test_events(UCM_EVENT_VM_UNMAPPED); + /* vm_unmap should be broken as well, because munmap is broken */ + status = ucm_test_events(UCM_EVENT_MUNMAP); + EXPECT_TRUE(status == UCS_ERR_UNSUPPORTED); + + /* mmap should still work */ + status = ucm_test_events(UCM_EVENT_MMAP); EXPECT_TRUE(status == UCS_OK); - /* restore original mmap body */ + /* restore original munmap body */ status = ucm_bistro_restore(rp); ASSERT_UCS_OK(status); }