Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4382

Closed
16 tasks done
joragua opened this issue Apr 15, 2024 · 1 comment · Fixed by #4482
Closed
16 tasks done

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4382

joragua opened this issue Apr 15, 2024 · 1 comment · Fixed by #4482

Comments

@joragua
Copy link
Collaborator

joragua commented Apr 15, 2024

Is your feature request related to a problem? Please describe.
When you are in a preview (text/image) and you click the (un)set as available offline button there aren't feedback and changes in button's name so it is confused because you don't know how the file is. Also there is a little glitch when you click in the menu. It seems that when you click one option in the menu, you are always clicking the first one.

Screen_recording_20240415_102230.mp4

Describe the solution you'd like
A little dialog related with the function that it is used, can be shown in the bottom of the screen. The same when you are in file's details. Also, change the label when the file is available offline or not.

Screen_recording_20240415_102625.mp4

TASKS

  • Research (if needed)
  • Create branch feature/add_feedback_in_preview_menu
  • Development tasks
    • Show a snackbar when (un)setting av.offline from text preview
    • Change the label of options menu in text preview
    • Show a snackbar when (un)setting av.offline from image preview
    • Change the label of options menu in image preview
    • Show a snackbar when (un)setting av.offline from audio preview
    • Change the label of options menu in audio preview
    • Show a snackbar when (un)setting av.offline from video preview
    • Change the label of options menu in video preview
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master
@JuancaG05
Copy link
Collaborator

This seems a good improvement! We should always give feedback to the user when they do any kind of action 😄

A Snackbar seems a good approach here when we press the (Un)set available offline button 👍

But, take into account that if the text doesn't change immediately is because the process of do/undo a file available offline takes a while (download the file or remove it), so we could show different Snackbars depending on the status of the process: one when it is being downloaded or removed and another one when it has already finished

@jesmrec jesmrec added this to the 4.3 - Current milestone Apr 19, 2024
@JuancaG05 JuancaG05 modified the milestones: 4.3 - Current, 4.4 - Future May 3, 2024
@jesmrec jesmrec changed the title [FEATURE REQUEST] Add feedback in preview menu [FEATURE REQUEST] Add status message in preview menu when setting av. offline from preview Jul 29, 2024
@jesmrec jesmrec changed the title [FEATURE REQUEST] Add status message in preview menu when setting av. offline from preview [FEATURE REQUEST] Add status message when setting av. offline from preview Jul 29, 2024
@jesmrec jesmrec changed the title [FEATURE REQUEST] Add status message when setting av. offline from preview [FEATURE REQUEST] Add status message when (un)setting av. offline from preview Jul 29, 2024
@Aitorbp Aitorbp modified the milestones: 4.4 - Current, 4.5 - Next Sep 20, 2024
@jesmrec jesmrec added the Sprint label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants