Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ink_e2e] update to new drink API #2005

Merged
merged 12 commits into from
Nov 24, 2023
Merged

[ink_e2e] update to new drink API #2005

merged 12 commits into from
Nov 24, 2023

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Nov 24, 2023

Updates the drink backend to be compatible with the latest API, specifically with changes done as part of inkdevhub/drink#84 by @pgherveou

⚠️ breaking change for e2e tests ⚠️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9401be) 53.24% compared to head (d505d6d) 53.32%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2005      +/-   ##
==========================================
+ Coverage   53.24%   53.32%   +0.08%     
==========================================
  Files         220      220              
  Lines        6846     6845       -1     
==========================================
+ Hits         3645     3650       +5     
+ Misses       3201     3195       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
basic-contract-caller 2.967 2.967 0 0
basic-contract-caller/other-contract 1.337 1.337 0 0
call-builder-return-value 8.735 8.735 0 0
call-runtime 1.769 1.769 0 0
conditional-compilation 1.209 1.209 0 0
contract-storage 7.171 7.171 0 0
contract-terminate 1.092 1.092 0 0
contract-transfer 1.444 1.444 0 0
custom-allocator 7.428 7.428 0 0
dns 7.249 7.249 0 0
e2e-call-runtime 1.058 1.058 0 0
e2e-runtime-only-backend 1.635 1.635 0 0
erc1155 13.968 13.968 0 0
erc20 6.687 6.687 0 0
erc721 9.64 9.64 0 0
events 4.763 4.763 0 0
flipper 1.393 1.393 0 0
incrementer 1.221 1.221 0 0
lang-err-integration-tests/call-builder-delegate 2.317 2.317 0 0
lang-err-integration-tests/call-builder 4.847 4.847 0 0
lang-err-integration-tests/constructors-return-value 1.773 1.773 0 0
lang-err-integration-tests/contract-ref 4.328 4.328 0 0
lang-err-integration-tests/integration-flipper 1.571 1.571 0 0
mapping-integration-tests 7.685 7.685 0 0
mother 9.508 9.508 0 0
multi-contract-caller 5.924 5.924 0 0
multi-contract-caller/accumulator 1.095 1.095 0 0
multi-contract-caller/adder 1.669 1.669 0 0
multi-contract-caller/subber 1.689 1.689 0 0
multisig 21.471 21.471 0 0
payment-channel 5.501 5.501 0 0
sr25519-verification 0.865 0.865 0 0
static-buffer 1.405 1.405 0 0
trait-dyn-cross-contract-calls 2.466 2.466 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.305 1.305 0 0
trait-erc20 7.063 7.063 0 0
trait-flipper 1.209 1.209 0 0
trait-incrementer 1.37 1.37 0 0
upgradeable-contracts/delegator 2.908 2.908 0 0
upgradeable-contracts/delegator/delegatee 1.369 1.369 0 0
upgradeable-contracts/set-code-hash 1.464 1.464 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.443 1.443 0 0
wildcard-selector 2.622 2.622 0 0

Link to the run | Last update: Fri Nov 24 18:59:32 CET 2023

@ascjones ascjones merged commit f7e831d into master Nov 24, 2023
22 checks passed
@ascjones ascjones deleted the aj/update-drink branch November 24, 2023 18:32
@SkymanOne SkymanOne mentioned this pull request Nov 30, 2023
ascjones added a commit that referenced this pull request Dec 4, 2023
* Update to latest drink version

* Update add_tokens to mint_into

* free_balance

* Trait bounds and generic balance

* Update API

* CHANGELOG.md

* Redundant From

* Redundant Send bounds

* Link to PR

* Clippy

* Clippy

* Fix
ascjones added a commit that referenced this pull request Dec 5, 2023
* Update to latest drink version

* Update add_tokens to mint_into

* free_balance

* Trait bounds and generic balance

* Update API

* CHANGELOG.md

* Redundant From

* Redundant Send bounds

* Link to PR

* Clippy

* Clippy

* Fix
@SkymanOne SkymanOne mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants