Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify collators to not produce blocks if there's an upcoming session change at the next relay chain block #5964

Open
alindima opened this issue Oct 8, 2024 · 4 comments
Labels
I5-enhancement An additional feature request. T9-cumulus This PR/Issue is related to cumulus.

Comments

@alindima
Copy link
Contributor

alindima commented Oct 8, 2024

Suggested in #5461 (comment)

It makes sense, because cores are freed on session change anyway so these candidates have no chance of being included.

@alindima alindima added I5-enhancement An additional feature request. T9-cumulus This PR/Issue is related to cumulus. labels Oct 8, 2024
@alindima alindima mentioned this issue Oct 8, 2024
7 tasks
@burdges
Copy link

burdges commented Oct 8, 2024

Interesting, well fair enough.

@bkchr
Copy link
Member

bkchr commented Oct 8, 2024

I'm still in favor of just dropping this requirement of dropping candidates on session boundaries. If the validator set doesn't change, there is no need to drop candidates.

Generally this issue is not really that useful. We have much more forks, which lead to "useless" blocks than we have session boundaries.

@burdges
Copy link

burdges commented Oct 9, 2024

We've no other reshuffling at session boundaries that screws up backing group assignments or whatever?

We could obviously avoid dropping candidates on session boundaries, but maybe we've higher priorities right now? How much time around the session boundaries?

@bkchr
Copy link
Member

bkchr commented Oct 9, 2024

Yeah for sure this is not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. T9-cumulus This PR/Issue is related to cumulus.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants