This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bitfield distribution flaky test #7281
Labels
I5-tests
Tests need fixing, improving or augmenting.
Comments
|
Probably because 10ms is indeed not enough in a multi-tenant environment? |
Yeah, overloaded CI machines I think. |
|
Never use timeouts in tests cough cough |
|
I agree that this is not a good practice in general, but in our case when testing subsystems we have this option versus the test hanging for much longer. I think we need to have some more lenient timeouts. |
|
Yeah or just have some "global" timeout that stops the test after 10 minutes. |
|
fixed in #7282 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
thread 'tests::changing_view' panicked at '10ms is more than enough for sending messages.', node/network/bitfield-distribution/src/tests.rs:571:9Happens every once in a while: https://github.com/paritytech/polkadot/blob/master/node/network/bitfield-distribution/src/tests.rs#L531
https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2885245
The text was updated successfully, but these errors were encountered: