Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Transfer gossiping messages from NetworkService straight to background tasks #6402

Closed
tomaka opened this issue Jun 18, 2020 · 0 comments · Fixed by #6692
Closed

Transfer gossiping messages from NetworkService straight to background tasks #6402

tomaka opened this issue Jun 18, 2020 · 0 comments · Fixed by #6692

Comments

@tomaka
Copy link
Contributor

tomaka commented Jun 18, 2020

At the moment, calling NetworkService::write_notifications synchronously verifies whether we have a connection with the peer, and if so sends a message on a channel in destination to the background task of this specific peer.

The problem is that this channel is already quite overloaded, and we should ideally try to reduce the traffic on this point of contention.
Additionally, we can't properly implement #5481 with this system.

Instead, there should be a field in NetworkService (not NetworkWorker) that directly contains channels whose receiving side are the background tasks.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant