Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairs creation is System 3 specific #22

Open
jrudoler opened this issue Aug 1, 2022 · 0 comments
Open

Pairs creation is System 3 specific #22

jrudoler opened this issue Aug 1, 2022 · 0 comments

Comments

@jrudoler
Copy link
Contributor

jrudoler commented Aug 1, 2022

Pairs includes constraints that are not relevant (MUX-related) and have distal references which are undesirable for system 4.

Question outstanding: should we add pairs that are compatible with other systems, or just include a warning in cmlreaders about pairs.json being system 3 specific?

def read_jacksheet(self,jacksheet):
nums_to_labels = {}
labels_to_nums = {}
with open(jacksheet) as jack_file:
for line in jack_file.read().splitlines():
num,label = line.strip().split()
num=int(num)
label=label
nums_to_labels[num] = label
labels_to_nums[label] = num
self.nums_to_labels = nums_to_labels
self.labels_to_nums = labels_to_nums
if self.reference_scheme == 'bipolar':
self.pairs_frame = bptools.pairs.create_pairs(jacksheet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant