[2.0.10] Bug - ODM - findByld

[Mont4]

Hi,
In ODM models, if id doesn't found in Database when using findByld function, the false value should be returned.

$id = 'not exist id';
$user = Users::findById($id);

if($user == false){
      // redirect
}

[sergeyklay]

What about:

if (!$user->count()) {
    // redirect
}

[Mont4]

when call findById($id) that id doesn't exist
this error happen.

Invalid object ID
#0 [internal function]: MongoId->__construct('s')
#1 [internal function]: Phalcon\Mvc\Collection::findById('s')
#2 /Users/iMohammad/Development/Phalcon/apps/backend/controllers/AdminAbstract.php(128): call_user_func(Array, 's')
#3 [internal function]: App\Backend\Controllers\AdminAbstract->confirmAction('s')
#4 [internal function]: Phalcon\Dispatcher->dispatch()
#5 /Users/iMohammad/Development/Phalcon/public/index.php(44): Phalcon\Mvc\Application->handle()
#6 {main}

[sergeyklay]

Hmm.. Okay. What about:

$user = Users::findById(new \MongoId('545eb081631d16153a293a66'));

In any case, what do you suggest? To add regexp to the findById like this?

/^(?=[a-f\d]{24}$)(\d+[a-f]|[a-f]+\d)/i

or

/^[a-f\d]{24}$/i

[Mont4]

Whenever this error occurs, it means id characters count are not 24.
I did not pay attention to that

[Mont4]

yes, it's good
tnx

[sergeyklay]

Fixed in the 2.1.x branch.