Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model field defaults to an empty string and is determined to be null #12507

Merged
merged 3 commits into from
Dec 28, 2016
Merged

Fix model field defaults to an empty string and is determined to be null #12507

merged 3 commits into from
Dec 28, 2016

Conversation

zGaron
Copy link

@zGaron zGaron commented Dec 26, 2016

as comment.
if the field is " not null default '' " in database.
model.zep:2091 while return null.

Thanks

@sergeyklay
Copy link
Contributor

@zGaron Could you please provide a small script to reproduce the issue?

@zGaron
Copy link
Author

zGaron commented Dec 26, 2016

@sergeyklay

just in update

@zGaron
Copy link
Author

zGaron commented Dec 28, 2016

hi @sergeyklay
I have added a unit test for this PR, please see if this is the one you want.

@sergeyklay
Copy link
Contributor

@zGaron Could you please submit this PR to the 3.0.x branch. I'll merge 3.0.x with 3.1.x later. Also update please CHANGELOG.md

@zGaron zGaron changed the base branch from 3.1.x to 3.0.x December 28, 2016 07:21
@zGaron zGaron changed the base branch from 3.0.x to 3.1.x December 28, 2016 07:21
@zGaron
Copy link
Author

zGaron commented Dec 28, 2016

@sergeyklay ok, on it

@zGaron zGaron changed the base branch from 3.1.x to 3.0.x December 28, 2016 07:32
@@ -13,6 +13,7 @@
- Fixed `Phalcon\Cache\Backend\Libmemcached::queryKeys` to correct query the existing cached keys [#11024](https://github.com/phalcon/cphalcon/issues/11024)
- Fixed building extension for ImageMagick 7 [mkoppanen/imagick#180](https://github.com/mkoppanen/imagick/issues/180)
- Fixed `Phalcon\Cache\Backend\Redis::save` to allow save data termlessly [#12327](https://github.com/phalcon/cphalcon/issues/12327)
- Fixed default value of the model is not correct properly when updating. [#12507](https://github.com/phalcon/cphalcon/issues/12507)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3.0.3 already released. Use 3.0.4 please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD
got it

@zGaron
Copy link
Author

zGaron commented Dec 28, 2016

@sergeyklay
Can I use [ci skip] when I just modify the CHANGELOG.md ?

@zGaron zGaron changed the title Fixed model field default value Fix model field defaults to an empty string and is determined to be null Dec 28, 2016
@sergeyklay sergeyklay merged commit 28e2c44 into phalcon:3.0.x Dec 28, 2016
@sergeyklay
Copy link
Contributor

Thanks

@zGaron zGaron deleted the bugfix/model-default-value branch April 12, 2017 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants