Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes not working #398

Open
StinkyTACO opened this issue Mar 3, 2023 · 16 comments
Open

themes not working #398

StinkyTACO opened this issue Mar 3, 2023 · 16 comments
Assignees
Labels

Comments

@StinkyTACO
Copy link

StinkyTACO commented Mar 3, 2023

i followed the info on https://docs.phpmyadmin.net/en/latest/setup.html#:~:text=Running%20with%20additional%20themes%3A

yet when i login the theme does not show up

this is my bind

image

im using the default phpmyadmin image

image

@ibennetch
Copy link
Member

Which theme(s) are you trying to add? I wonder if they are compatible with your phpMyAdmin version.

@StinkyTACO
Copy link
Author

Blueberry theme from the official repo version of php is 5.2.1 and theme is for 5.2

@StinkyTACO
Copy link
Author

Screenshot_20230303_040914_Chrome

@StinkyTACO
Copy link
Author

Screenshot_20230303_041444_Chrome

@williamdes williamdes added the discussion A discussion label Mar 3, 2023
@StinkyTACO
Copy link
Author

would there be any news on this yet?

@williamdes
Copy link
Member

would there be any news on this yet?

Yes, I found what's wrong re-reading your post.
The bind folder is wrong, see here the root:

tar -xf phpMyAdmin.tar.xz -C /var/www/html --strip-components=1; \

So it should be mounted to /var/www/html/themes/mytheme

@williamdes williamdes added question and removed discussion A discussion labels Mar 5, 2023
@williamdes williamdes self-assigned this Mar 5, 2023
@StinkyTACO
Copy link
Author

would this not mean the documentation is wrong?

@StinkyTACO
Copy link
Author

i can confirm the updated info does work

@williamdes
Copy link
Member

would this not mean the documentation is wrong?

What documentation?
I did not find this on the README, I will add how to mount themes

@williamdes
Copy link
Member

Thank you, that's a very strange folder for themes. Did it work someday?
I need to research that

@williamdes
Copy link
Member

Seems to have been since #203 (comment) and here is another post where someone also used this mount path: #333 (comment)

So I found out it's since 662b82d (#198)

The best is that we now update our documentation

@williamdes
Copy link
Member

williamdes commented Mar 9, 2023

@tianon on the same subject as this issue, with #198 & #274 we no longer can mount sessions to /sessions
I found a message of yours about that in: docker-library/php#201 (comment)

Can we create a new folder /sessions and change the php ini config to this folder or is it not a good change for an official image ?
/cc @J0WI
Currently session.save_path => no value, would be changed to session.save_path => /sessions/
What would be the best permissions for such a folder ?, for rootless compatibility ?

@tianon
Copy link
Contributor

tianon commented Mar 10, 2023

If this makes sense for how you want phpMyAdmin users to consume the image, it's totally fine (we just don't feel comfortable make such a general sweeping change in the php images directly).

If you want rootless compatibility, I'd suggest 1777 (matching typical /tmp permissions).

@J0WI
Copy link
Contributor

J0WI commented Mar 21, 2023

Alternatively, you could configure an external Redis or Memcached container as PHP session handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants