Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad usage of global functions. #44

Closed
ryanhowdy opened this issue Apr 6, 2023 · 2 comments
Closed

Bad usage of global functions. #44

ryanhowdy opened this issue Apr 6, 2023 · 2 comments
Assignees
@MauricioFauth
Labels
bug
Milestone
5.3.1

Comments

@ryanhowdy
Copy link

Cannot redeclare __() (previously declared in /var/www/site/vendor/laravel/framework/src/Illuminate/Foundation/helpers.php:967

This package does not work with Laravel, and possible others because of the usage of global functions.

It would be great if you would wrap all the global functions in an if (!function_exists()) call to ensure this does not happen.
@williamdes williamdes added the bug label Apr 6, 2023
@williamdes
Copy link
Member

Thank you for reporting this @ryanhowdy !

@MauricioFauth MauricioFauth self-assigned this Aug 23, 2023
@MauricioFauth MauricioFauth mentioned this issue Aug 23, 2023
Merged
@williamdes williamdes added this to the 5.4.0 milestone Aug 23, 2023
@williamdes
Copy link
Member

Fixed by #45

@williamdes williamdes reopened this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MauricioFauth MauricioFauth

Labels
bug
Projects
None yet
Milestone
5.3.1
Development

No branches or pull requests
3 participants
@ryanhowdy @MauricioFauth @williamdes