Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ShapeType class to be an enum #29

Open
MauricioFauth opened this issue Sep 19, 2023 · 0 comments
Open

Change the ShapeType class to be an enum #29

MauricioFauth opened this issue Sep 19, 2023 · 0 comments
Labels
enhancement help wanted
Milestone
4.0.0

Comments

@MauricioFauth
Copy link
Member

The PhpMyAdmin\ShapeFile\ShapeType class should be changed to a PHP backed enum and the ShapeType constants should be turned into enum cases.

Currently, the ShapeFile class accepts any integer as a shape type. Only the shape type defined in the ShapeType class should be accepted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@MauricioFauth