Recognize question mark as parameter, add formatter for parameters

phpmyadmin · Apr 19, 2019 · 3adf389 · 3adf389
1 parent 0eb16ef
commit 3adf389
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 2 deletions.
diff --git a/src/Context.php b/src/Context.php
@@ -389,7 +389,7 @@ public static function isSymbol($str)
             return Token::FLAG_SYMBOL_VARIABLE;
         } elseif ($str[0] === '`') {
             return Token::FLAG_SYMBOL_BACKTICK;
-        } elseif ($str[0] === ':') {
+        } elseif ($str[0] === ':' || $str[0] === '?') {
             return Token::FLAG_SYMBOL_PARAMETER;
         }
 

diff --git a/src/Lexer.php b/src/Lexer.php
@@ -872,7 +872,7 @@ public function parseSymbol()
                 $flags |= Token::FLAG_SYMBOL_SYSTEM;
             }
         } elseif ($flags & Token::FLAG_SYMBOL_PARAMETER) {
-            if ($this->last + 1 < $this->len) {
+            if ('?' !== $token && $this->last + 1 < $this->len) {
                 ++$this->last;
             }
         } else {

diff --git a/src/Utils/Formatter.php b/src/Utils/Formatter.php
@@ -225,6 +225,13 @@ protected function getDefaultFormats()
                 'cli' => "\x1b[91m",
                 'function' => '',
             ),
+            array(
+                'type' => Token::TYPE_SYMBOL,
+                'flags' => Token::FLAG_SYMBOL_PARAMETER,
+                'html' => 'class="sql-parameter"',
+                'cli' => "\x1b[31m",
+                'function' => '',
+            ),
             array(
                 'type' => Token::TYPE_SYMBOL,
                 'flags' => 0,

diff --git a/tests/Lexer/TokenTest.php b/tests/Lexer/TokenTest.php
@@ -74,6 +74,12 @@ public function testExtractSymbol()
 
         $tok = new Token('@`foo`', Token::TYPE_SYMBOL, Token::FLAG_SYMBOL_VARIABLE);
         $this->assertEquals($tok->value, 'foo');
+
+        $tok = new Token(':foo', Token::TYPE_SYMBOL, Token::FLAG_SYMBOL_PARAMETER);
+        $this->assertEquals($tok->value, 'foo');
+
+        $tok = new Token('?', Token::TYPE_SYMBOL, Token::FLAG_SYMBOL_PARAMETER);
+        $this->assertEquals($tok->value, '?');
     }
 
     public function testInlineToken()

diff --git a/tests/Utils/FormatterTest.php b/tests/Utils/FormatterTest.php
@@ -506,6 +506,48 @@ public function formatQueries()
                     "\x1b[0m",
                 'html' => '<span class="sql-reserved">JOIN</span> tbl2 <span class="sql-reserved">ON</span> c1 = c2',
             ),
+            'named param' => array(
+                'query' => 'select * from tbl where col = :param',
+                'text' => 'SELECT' . "\n" .
+                    '    *' . "\n" .
+                    'FROM' . "\n" .
+                    '    tbl' . "\n" .
+                    'WHERE' . "\n" .
+                    '    col = :param',
+                'cli' => "\x1b[35mSELECT" . "\n" .
+                    "    \x1b[39m*" . "\n" .
+                    "\x1b[35mFROM" . "\n" .
+                    "    \x1b[39mtbl" . "\n" .
+                    "\x1b[35mWHERE" . "\n" .
+                    "    \x1b[39mcol = \x1b[31m:param" . "\x1b[0m",
+                'html' => '<span class="sql-reserved">SELECT</span>' . '<br/>' .
+                    '&nbsp;&nbsp;&nbsp;&nbsp;*' . '<br/>' .
+                    '<span class="sql-reserved">FROM</span>' . '<br/>' .
+                    '&nbsp;&nbsp;&nbsp;&nbsp;tbl' . '<br/>' .
+                    '<span class="sql-reserved">WHERE</span>' . '<br/>' .
+                    '&nbsp;&nbsp;&nbsp;&nbsp;col = <span class="sql-parameter">:param</span>',
+            ),
+            'anon param' => array(
+                'query' => 'select * from tbl where col = ?',
+                'text' => 'SELECT' . "\n" .
+                    '    *' . "\n" .
+                    'FROM' . "\n" .
+                    '    tbl' . "\n" .
+                    'WHERE' . "\n" .
+                    '    col = ?',
+                'cli' => "\x1b[35mSELECT" . "\n" .
+                    "    \x1b[39m*" . "\n" .
+                    "\x1b[35mFROM" . "\n" .
+                    "    \x1b[39mtbl" . "\n" .
+                    "\x1b[35mWHERE" . "\n" .
+                    "    \x1b[39mcol = \x1b[31m?" . "\x1b[0m",
+                'html' => '<span class="sql-reserved">SELECT</span>' . '<br/>' .
+                    '&nbsp;&nbsp;&nbsp;&nbsp;*' . '<br/>' .
+                    '<span class="sql-reserved">FROM</span>' . '<br/>' .
+                    '&nbsp;&nbsp;&nbsp;&nbsp;tbl' . '<br/>' .
+                    '<span class="sql-reserved">WHERE</span>' . '<br/>' .
+                    '&nbsp;&nbsp;&nbsp;&nbsp;col = <span class="sql-parameter">?</span>',
+            ),
         );
     }
 }