Missing mysql 8 statements

[andrewchernow]

Any plans to add the VALUES and WITH (CTE) statements? I am in need of detecting any statement that can produce results.

[williamdes]

Hi,
Any implementation would be very welcome :)
We are open to contributions, any help on this repository would be awesome

[andrewchernow]

I wish I could. Between all my projects and work, I don't have the time. It is curious though, that mysql 8 was released 3 years ago and these new statements are still not supported? Yet, you committed 9 days ago?

[williamdes]

I wish I could. Between all my projects and work, I don't have the time. It is curious though, that mysql 8 was released 3 years ago and these new statements are still not supported? Yet, you committed 9 days ago?

I understand

On this repository there is some work to support new syntaxes, the code is improved but not much new features are written.
I did not write the code for this repository, and you can have a look but it is not always easy to understand how the parsing works this is for me the main reason I did not start writing features here
But this is for sure a topic and I hope to get this moving on in the next months

[andrewchernow]

Really? I mean, it can'y be too hard. Let me look. Maybe I can patch it to support these new statements. I am swamped but I will look at it further.

[williamdes]

Really? I mean, it can'y be too hard

It's not that hard but for me it's discouraging
My first task when I will switch on this repository will be to change the tests output files to something readable by humans so anyone can check the diffs between objects when adding features

In fact I do not feel enough confortable about the implementing and not breaking things part of it.
One very good thing is that this project has a very good code coverage and I wrote the missing tests a while ago

Conclusion: a better way to dump objects in tests and then new features

I hope this was not to much a messy explanation

[andrewchernow]

Got it. Sorry, my comment may have come off insulting. That was not my intent.

[williamdes]

Got it. Sorry, my comment may have come off insulting. That was not my intent.

No worries, you are just asking good questions :)

[williamdes]

WITH will be part of 5.5.0
Implemented in: #334

[williamdes]

This will help tests output and their changes to be understood: 9f16b24