Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] ImportSST::Upload and Ingest rpc method can be used or not ? #895

Open
mzygQAQ opened this issue Mar 31, 2022 · 1 comment
Open

Comments

@mzygQAQ
Copy link

mzygQAQ commented Mar 31, 2022

i notice that the upload and ingest methods:
I wonder if it can be used to import SST files into tikv(used with txn-client) ?

rpc Upload(stream UploadRequest) returns (UploadResponse) {}
// Ingest an uploaded SST file to a region.
rpc Ingest(IngestRequest) returns (IngestResponse) {}

I checked the source code of some import tools of tidb like tikv-br, tidb-lightning and found that they did not use these two interfaces (upload and ingest), but called importsst:: write / rawwrite. Why?

rpc Write(stream WriteRequest) returns (WriteResponse) {}
rpc RawWrite(stream RawWriteRequest) returns (RawWriteResponse) {}

@disksing
Copy link
Contributor

disksing commented Apr 1, 2022

/cc @overvenus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants