Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to tikv/proto #913

Open
breezewish opened this issue May 10, 2022 · 6 comments
Open

Move to tikv/proto #913

breezewish opened this issue May 10, 2022 · 6 comments

Comments

@breezewish
Copy link
Member

breezewish commented May 10, 2022 •
edited
Loading

As a protobuf of TiKV, it should be placed with other TiKV ecosystems, e.g. located in github.com/tikv/proto.

Related: #912
@BusyJay
Copy link
Contributor

BusyJay commented May 10, 2022

+1

@disksing
Copy link
Contributor

I think it is generally a good idea. But there are TiDB specific protocols too. We may want to split it into 2 repos.

@BusyJay
Copy link
Contributor

BusyJay commented May 17, 2022

But there are TiDB specific protocols too.

Can you name a few?

@breezewish
Copy link
Member Author

Maybe we can have a rule about what to be moved out in the stage 1: what tikv/tikv code base is relying on, could be placed in tikv/proto (even if conceptually it is not related with TiKV but only happens to be placed in TiKV). What tikv/tikv code base is not relying on, should be moved out in stage 1. This will reduce the surface of the change.

@TennyZhuang
Copy link

Any update?

@TennyZhuang
Copy link

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BusyJay @breezewish @TennyZhuang @disksing