checker: fix the issue that a region does not merge to the sibling with smaller size (#1723) #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
rleungx
approved these changes
Sep 3, 2019
rleungx
reviewed
Sep 3, 2019
| targetNext := m.checkTarget(region, next, target) | ||
| target = m.checkTarget(region, prev, target) | ||
| if target != targetNext && m.cluster.GetEnableOneWayMerge() { | ||
| checkerCounter.WithLabelValues("merge_checker", "skip_left").Inc() |
There was a problem hiding this comment.
BTW, do we need to keep the metrics?
nolouch
approved these changes
Sep 4, 2019
nolouch
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1723 to release-3.0
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
The
targetargument passed tocheckTargetis alwaysnil, sonextandprevare never compared.What is changed and how it works?
Make it right and clear and add test.
Check List
Tests
Related changes