Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_execution_time doesn't contain get tso time #51893

Open
aytrack opened this issue Mar 19, 2024 · 4 comments · May be fixed by #56087
Open

max_execution_time doesn't contain get tso time #51893

aytrack opened this issue Mar 19, 2024 · 4 comments · May be fixed by #56087

Comments

@aytrack
Copy link
Contributor

aytrack commented Mar 19, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

from https://asktug.com/t/topic/1023086

  1. set max_execution_time = 3000
  2. execute sql get tso from pd exceed 3s
    图片

2. What did you expect to see? (Required)

the query should interrupted after 3s

3. What did you see instead (Required)

the query run longer than 3s

4. What is your TiDB version? (Required)

master

@aytrack aytrack added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/moderate labels Mar 19, 2024
@djshow832 djshow832 added sig/execution SIG execution and removed sig/sql-infra SIG: SQL Infra labels Mar 22, 2024
@yibin87
Copy link
Contributor

yibin87 commented Apr 28, 2024

/severity major

@yibin87
Copy link
Contributor

yibin87 commented Apr 28, 2024

/remove-severity moderate

@aytrack aytrack added the report/community The community has encountered this bug. label Jun 3, 2024
@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Sep 14, 2024

After asking help from @MyonKeminta , this is related to transaction and pd-client module.

  1. DurationWaitTs is the get tso duration.
  2. tf.future.Wait() is the main waiting function, it's an pd-client interface, but this interface doesn't has any method to interrupt get tso process.
  3. need change pd-client to add method to interrupt getting tso process: tsoRequest

@guo-shaoge guo-shaoge added sig/transaction SIG:Transaction and removed sig/execution SIG execution labels Sep 14, 2024
@guo-shaoge guo-shaoge linked a pull request Sep 14, 2024 that will close this issue
13 tasks
@cfzjywxk
Copy link
Contributor

@guo-shaoge
I think the severity could be lowered, in most cases it would be a big problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants