Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix single concurrency analyze blocking #56074

Closed
wants to merge 1 commit into from
Closed

statistics: fix single concurrency analyze blocking #56074

wants to merge 1 commit into from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #56071

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
statistics: fix single concurrency analyze
99656c9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 13, 2024
@hawkingrei hawkingrei changed the title statistics: fix single concurrency analyze statistics: fix single concurrency analyze blocking Sep 13, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.1302%. Comparing base (027f01b) to head (99656c9).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #56074         +/-   ##
=================================================
- Coverage   72.8742%   56.1302%   -16.7441%     
=================================================
  Files          1604       1729        +125     
  Lines        446838     623186     +176348     
=================================================
+ Hits         325630     349796      +24166     
- Misses       101150     249632     +148482     
- Partials      20058      23758       +3700
Flag Coverage Δ
integration 37.2832% <100.0000%> (?)
unit 72.0131% <100.0000%> (+0.0223%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8757% <ø> (+7.2453%) ⬆️

@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2024
@hawkingrei hawkingrei closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analyze may block forever
1 participant
@hawkingrei