From e35b39fc6bea227d1a0596588a0cfdc46178252b Mon Sep 17 00:00:00 2001
From: Baz Utsahajit <baz.utsahajit@play.co>
Date: Thu, 8 Feb 2024 12:15:52 +0000
Subject: [PATCH] Chore: Emboss Filter Tweaks

---
 src/emboss/EmbossFilter.ts | 27 +++++++--------------------
 1 file changed, 7 insertions(+), 20 deletions(-)

diff --git a/src/emboss/EmbossFilter.ts b/src/emboss/EmbossFilter.ts
index f4dc29703..0de52b293 100644
--- a/src/emboss/EmbossFilter.ts
+++ b/src/emboss/EmbossFilter.ts
@@ -3,15 +3,6 @@ import { vertex, wgslVertex } from '../defaults';
 import fragment from './emboss.frag';
 import source from './emboss.wgsl';
 
-export interface EmbossFilterOptions
-{
-    /**
-     * Strength of the emboss
-     * @default 5
-     */
-    strength?: number;
-}
-
 /**
  * An RGB Split Filter.<br>
  * ![original](../screenshots/original.png)![filter](../screenshots/emboss.png)
@@ -22,20 +13,16 @@ export interface EmbossFilterOptions
  */
 export class EmbossFilter extends Filter
 {
-    /** Default values for options. */
-    public static readonly DEFAULT_OPTIONS: EmbossFilterOptions = {
-        strength: 5,
-    };
-
     public uniforms: {
         uStrength: number;
     };
 
-    constructor(options?: EmbossFilterOptions)
+    /**
+     * @param {number} [strength=5] - Strength of the emboss.
+     */
+    constructor(strength = 5)
     {
-        options = { ...EmbossFilter.DEFAULT_OPTIONS, ...options };
-
-        const gpuProgram = new GpuProgram({
+        const gpuProgram = GpuProgram.from({
             vertex: {
                 source: wgslVertex,
                 entryPoint: 'mainVertex',
@@ -46,7 +33,7 @@ export class EmbossFilter extends Filter
             },
         });
 
-        const glProgram = new GlProgram({
+        const glProgram = GlProgram.from({
             vertex,
             fragment,
             name: 'emboss-filter',
@@ -57,7 +44,7 @@ export class EmbossFilter extends Filter
             glProgram,
             resources: {
                 embossUniforms: {
-                    uStrength: { value: options.strength, type: 'f32' },
+                    uStrength: { value: strength, type: 'f32' },
                 }
             },
         });