From 877bd827dc61b0d14e9bd03d750656f77a46886e Mon Sep 17 00:00:00 2001 From: Jinghua Yao Date: Wed, 21 Jun 2023 17:18:29 -0700 Subject: [PATCH] Revert "fix: creating a new chart with dashboard time filters but filter can't apply again (#24405)" This reverts commit 6dba6e32f55d719ec49cb5e6dc2fdd07a0b694df. --- .../src/explore/actions/saveModalActions.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/superset-frontend/src/explore/actions/saveModalActions.js b/superset-frontend/src/explore/actions/saveModalActions.js index de4f7af84c37e..9bd5161391539 100644 --- a/superset-frontend/src/explore/actions/saveModalActions.js +++ b/superset-frontend/src/explore/actions/saveModalActions.js @@ -83,19 +83,6 @@ export const getSlicePayload = ( adhocFilters = extractAddHocFiltersFromFormData(formDataFromSlice); } - if ( - isEmpty(adhocFilters?.adhoc_filters) && - isEmpty(formDataFromSlice) && - formDataWithNativeFilters?.adhoc_filters?.length > 0 - ) { - adhocFilters.adhoc_filters = [ - { - ...formDataWithNativeFilters.adhoc_filters[0], - comparator: 'No filter', - }, - ]; - } - const formData = { ...formDataWithNativeFilters, ...adhocFilters,