Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong emit on accordion open #10509

Closed
martinkasa opened this issue Aug 17, 2021 · 0 comments
Closed

Wrong emit on accordion open #10509

martinkasa opened this issue Aug 17, 2021 · 0 comments
Assignees
@yigitfindikli
Labels
LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
13.0.1

Comments

@martinkasa
Copy link

martinkasa commented Aug 17, 2021 •
edited
Loading

https://stackblitz.com/edit/github-yqtqpy-a6ykuu

Current behavior
If accordion is not set to multiple, open event always emits two values, first "false" and then "true". This does not happen on close event.

Expected behavior
Only one value should be emited.

Minimal reproduction of the problem with instructions
I created stackblitz workspace to reproduce the issue, check the console. Possible cause is here, where you can see that if multiple is not set, it always emits false and then it emits again actual value.

https://github.com/primefaces/primeng/blob/master/src/app/components/accordion/accordion.ts#L134

  • Angular version: 12.2.1
  • PrimeNG version: 12.0.1
  • Browser: Chrome 92
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 17, 2021
@yigitfindikli yigitfindikli added this to the 12.Future milestone Aug 17, 2021
@yigitfindikli yigitfindikli self-assigned this Aug 17, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 30, 2021
@yigitfindikli yigitfindikli modified the milestones: 13.Future, 13.0.1 Nov 30, 2021
@yigitfindikli yigitfindikli mentioned this issue Dec 8, 2021
Closed
@yigitfindikli yigitfindikli added LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 and removed LTS-PORTABLE labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
LTS-FIXED-11.4.10 Fixed in PrimeNG LTS 11.4.10 LTS-FIXED-12.2.5 Fixed in PrimeNG LTS 12.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
13.0.1
Development

No branches or pull requests
2 participants
@yigitfindikli @martinkasa