Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: MultiSelect #14617

Closed
jimguistwite opened this issue Jan 23, 2024 · 3 comments · Fixed by #14997
Closed

Component: MultiSelect #14617

jimguistwite opened this issue Jan 23, 2024 · 3 comments · Fixed by #14997
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jimguistwite
Copy link

Describe the bug

When MultiSelect toggleAll is invoked, disabled items become de-selected. Prior versions of the library did not de-select disabled items. As a result, after toggle all is again clicked, the disabled items are now unselected.

image image image

Environment

https://stackblitz.com/edit/github-ry5j6r?file=src%2Fapp%2Fapp.component.ts

Reproducer

https://stackblitz.com/edit/github-ry5j6r?file=src%2Fapp%2Fapp.component.html

Angular version

17.0.9

PrimeNG version

17.3.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@jimguistwite jimguistwite added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 23, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 5, 2024
@VolodymyrKornetskyi
Copy link

I double checked source code and figure out that property toggleAllDisabled is removed from component but still using in html. Guys please double check multiselect component for issues

@thaihacong
Copy link

The logic is broken here

const value = this.allSelected()
.
image

In old working versions, it was done like in

.
image

@cetincakiroglu
Copy link
Contributor

Fixed in #14997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants