Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog.onShow should occur when the animation ends #8747

Closed
mconner opened this issue Apr 16, 2020 · 0 comments
Closed

Dialog.onShow should occur when the animation ends #8747

mconner opened this issue Apr 16, 2020 · 0 comments
Assignees
Labels
LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mconner
Copy link

mconner commented Apr 16, 2020

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~8-12 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/github-baa3wj

Current behavior

The code emits for onShow shortly after (~10ms) the show animation starts.
Expected behavior

It should occur when the animation ends. I can determine when the show starts because it is based on the visible value, which is under my control. but there is no event emitted when the show animation ends.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Windows 10

  • Angular version: 5.X
  • PrimeNG version: 9.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript
  • Node (for AoT issues): node --version =
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 23, 2020
@cagataycivici cagataycivici added this to the 11.0.0-rc.2 milestone Nov 23, 2020
@yigitfindikli yigitfindikli added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 25, 2020
@yigitfindikli yigitfindikli added LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 and removed LTS-PORTABLE labels Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants