Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PColumnFilter's apply and clear button arent hiding if [showApplyButton] or [showClearButton] are set to false #9654

Closed
dennis-mysign opened this issue Dec 15, 2020 · 7 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dennis-mysign
Copy link

I'm submitting a ... (check one with "x")

[ x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/primeng-tablefilter-demo-fupw4q?file=src%2Fapp%2Fapp.component.html

Current behavior
Setting ShowApplyButton or ShowClearButton to false, doesn't hide the apply- or the clear-button on the pColumnFilter

Expected behavior
Setting ShowApplyButton or ShowClearButton to false, should hide the apply- or the clear-button on the pColumnFilter

What is the motivation / use case for changing the behavior?
To be able to create custom buttons, which are using the filterCallback, for applying or clearing filters on the pColumnFilter.

  • Angular version: 11.X
  • PrimeNG version: 11.X
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 15, 2020
@yigitfindikli yigitfindikli self-assigned this Dec 15, 2020
@chapoub
Copy link

chapoub commented Feb 9, 2021

I had the same issue today with
angular v11.1.1
primeng v11.2.0

Do you plan to solve this issue anytime soon?

Thanks,

@jroovers
Copy link

jroovers commented Feb 16, 2021

I also have this problem

angular v11.1.0
primeng v11.2.0

@balagex
Copy link

balagex commented Mar 3, 2021

I also have this problem. (angular 11.1.1 ; primeng 11.2.0)

@Sayali77
Copy link

Sayali77 commented Apr 1, 2021

I also have this problem angular v11.1.0 primeng v11.2.0

@AyhamJaradat
Copy link

I also have this problem

1 similar comment
@jesuspa17
Copy link

I also have this problem

@agarofalotecnetsys
Copy link

I have same problem

@yigitfindikli yigitfindikli added this to the 11.4.0 milestone Apr 15, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

9 participants