Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Probot v13 #128

Merged
merged 5 commits into from
Jun 20, 2024
Merged

feat: Support Probot v13 #128

merged 5 commits into from
Jun 20, 2024

Conversation

Oatelaus
Copy link
Contributor

@Oatelaus Oatelaus commented Jun 17, 2024

This PR updates Probot to v13 and replaces nock with fetch-mock.

When attempting to use this package with other packages including functionality built around newer webhook events I came across issues with mismatching @octokit/webhooks-types (or just @octokit/wehooks)

As per octokit/core.js#551 it is recommended to capture outgoing fetch requests using fetch-mock over nock.

I have dropped out the dependency for @probot/get-private-key as this is not directly used within this package anymore.

@Oatelaus
Copy link
Contributor Author

@gr2m if you have a moment could you have a peak at this? 🙏

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for that! I didn't test it but I'm going to trust you on this one 👍🏼

@gr2m
Copy link
Contributor

gr2m commented Jun 19, 2024

Hmm I'm okay with dropping the tests for node 14 & 16 and test in 20 and 22 instead

Do you know what node version lambda is using?

@Oatelaus
Copy link
Contributor Author

Oatelaus commented Jun 19, 2024

@gr2m judging by https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html it looks like:

20 - No Planned Deprecation
18 - No Planned Deprecation
16 - Jun 12, 2024

I would need to look into the specifics to get 16 to work or would you prefer to go with just 18 & 20?

Learn about the languages that Lambda supports through runtimes.

@gr2m
Copy link
Contributor

gr2m commented Jun 19, 2024

great, thanks for checking! Can you update the test matrix as part of this PR?

@Oatelaus
Copy link
Contributor Author

Oatelaus commented Jun 20, 2024

Thanks for the advice @gr2m I've done that!

Looks like Probot has dropped support for anything below 18 probot/probot@948a1b7

I realise I haven't tested in 22, I left it out because it's not a supported AWS version, however I see sense in adding it in as a future proofing mechanism.

@gr2m
Copy link
Contributor

gr2m commented Jun 20, 2024

I realise I haven't tested in 22, I left it out because it's not a supported AWS version, however I see sense in adding it in as a future proofing mechanism.

That's okay, we can add it later

@gr2m gr2m merged commit aa64b4e into probot:master Jun 20, 2024
4 checks passed
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants