Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper relative path to protobufjs in cli #1753

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

maitbayev
Copy link
Contributor

@maitbayev maitbayev commented Jun 22, 2022

According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#local-paths the local path should be file:.. instead of file://...

The later version copies whole top-level file-system on a macOS and with a recent version of npm (8.12.2). As a result , it errors with message Cannot find module 'protobufjs'

According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#local-paths the local path should be `file:..` instead of `file://..`.

The later version copies whole top-level file-system in a macOS and with a recent version of npm (8.12.2) and results in a `MODULE_NOT_FOUND` error.
@maitbayev
Copy link
Contributor Author

cc @bcoe @dcodeIO

@alexander-fenster
Copy link
Contributor

Going to merge this as soon as I figure out the CI problem (doing it now).

@alexander-fenster alexander-fenster changed the title Fix the relative path to protobufjs in cli fix: proper relative path to protobufjs in cli Jul 7, 2022
@alexander-fenster alexander-fenster merged commit a1d6029 into protobufjs:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants