Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not let setProperty change the prototype #1899

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

alexander-fenster
Copy link
Contributor

Follow up to #1731, fixes a bug introduced in #1256.

src/util.js Show resolved Hide resolved
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-fenster alexander-fenster merged commit e66379f into master Jun 23, 2023
@alexander-fenster alexander-fenster deleted the constructor branch June 23, 2023 22:46
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
jportner pushed a commit to jportner/protobuf.js that referenced this pull request Jul 10, 2023
* fix: do not let setProperty change the prototype

* test: add unit test
alexander-fenster added a commit that referenced this pull request Aug 11, 2023
* fix: do not let setProperty change the prototype

* test: add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants