Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for reserved type #676

Closed

Conversation

schwiet
Copy link

@schwiet schwiet commented Feb 11, 2017

Only this case was being handled:

reserved 10 to 20;

But all of the following are valid (source):

reserved 2, 15, 9 to 11;
reserved "foo", "bar";

Files with reserved names or comma separated numbers would not compile. This is my attempt to handle all cases in a way that is consistent with the existing codebase.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.83% when pulling abba570 on schwiet:full-reserved-type-support into 2ddb76b on dcodeIO:master.

@dcodeIO
Copy link
Member

dcodeIO commented Feb 24, 2017

Please let me know if the latest commit solves your issue!

@dcodeIO
Copy link
Member

dcodeIO commented Mar 1, 2017

Should be working as of 6.6.4. Feel free to reopen if there are still any issues!

@dcodeIO dcodeIO closed this Mar 1, 2017
@schwiet
Copy link
Author

schwiet commented Mar 5, 2017

Yes, looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants